window: Drop some x11-specific apis
authorMatthias Clasen <mclasen@redhat.com>
Sat, 20 Apr 2019 01:13:41 +0000 (01:13 +0000)
committerMatthias Clasen <mclasen@redhat.com>
Sat, 20 Apr 2019 02:28:46 +0000 (02:28 +0000)
The skip-taskbar, skip-pager and urgency hints were
only ever implemented for X11, and are not very useful
with modern desktops. Relegate the functionality to
x11 backend api, and drop the GtkWindow api.

15 files changed:
docs/reference/gdk/gdk4-sections.txt
docs/reference/gtk/gtk4-sections.txt
gdk/broadway/gdksurface-broadway.c
gdk/gdksurface.c
gdk/gdksurface.h
gdk/gdksurfaceimpl.h
gdk/quartz/gdksurface-quartz.c
gdk/wayland/gdksurface-wayland.c
gdk/win32/gdksurface-win32.c
gdk/win32/gdkwin32surface.h
gdk/x11/gdksurface-x11.c
gdk/x11/gdkx11surface.h
gtk/gtkmessagedialog.c
gtk/gtkwindow.c
gtk/ui/gtkmessagedialog.ui

index fb68d5aec0c2a838ee4c33d4b0165e075045c703..41ec4d7e50bfb0205e8438fcfc3297c8d54cc58e 100644 (file)
@@ -262,9 +262,6 @@ gdk_surface_get_modal_hint
 gdk_surface_set_type_hint
 gdk_surface_get_type_hint
 gdk_surface_set_shadow_width
-gdk_surface_set_skip_taskbar_hint
-gdk_surface_set_skip_pager_hint
-gdk_surface_set_urgency_hint
 gdk_surface_get_position
 gdk_surface_get_root_origin
 gdk_surface_get_frame_extents
index 96d08652ddd35b7736292eea83a43d12d8e3adcd..233128353148b86634b70d731707a1f66d279d1b 100644 (file)
@@ -4694,9 +4694,6 @@ gtk_window_set_decorated
 gtk_window_set_deletable
 gtk_window_set_mnemonic_modifier
 gtk_window_set_type_hint
-gtk_window_set_skip_taskbar_hint
-gtk_window_set_skip_pager_hint
-gtk_window_set_urgency_hint
 gtk_window_set_accept_focus
 gtk_window_set_focus_on_map
 gtk_window_set_startup_id
@@ -4713,9 +4710,6 @@ gtk_window_get_title
 gtk_window_get_transient_for
 gtk_window_get_attached_to
 gtk_window_get_type_hint
-gtk_window_get_skip_taskbar_hint
-gtk_window_get_skip_pager_hint
-gtk_window_get_urgency_hint
 gtk_window_get_accept_focus
 gtk_window_get_focus_on_map
 gtk_window_get_group
index 732d2a7fd64c9c9e00a6453218a5f0e634aab1a7..a76b641a40fd7ac1b7bee855a25cb8e6a35531df 100644 (file)
@@ -473,24 +473,6 @@ gdk_broadway_surface_set_modal_hint (GdkSurface *surface,
 {
 }
 
-static void
-gdk_broadway_surface_set_skip_taskbar_hint (GdkSurface *surface,
-                                            gboolean   skips_taskbar)
-{
-}
-
-static void
-gdk_broadway_surface_set_skip_pager_hint (GdkSurface *surface,
-                                          gboolean   skips_pager)
-{
-}
-
-static void
-gdk_broadway_surface_set_urgency_hint (GdkSurface *surface,
-                                       gboolean   urgent)
-{
-}
-
 static void
 gdk_broadway_surface_set_geometry_hints (GdkSurface         *surface,
                                          const GdkGeometry *geometry,
@@ -1356,9 +1338,6 @@ gdk_surface_impl_broadway_class_init (GdkSurfaceImplBroadwayClass *klass)
   impl_class->set_type_hint = gdk_broadway_surface_set_type_hint;
   impl_class->get_type_hint = gdk_broadway_surface_get_type_hint;
   impl_class->set_modal_hint = gdk_broadway_surface_set_modal_hint;
-  impl_class->set_skip_taskbar_hint = gdk_broadway_surface_set_skip_taskbar_hint;
-  impl_class->set_skip_pager_hint = gdk_broadway_surface_set_skip_pager_hint;
-  impl_class->set_urgency_hint = gdk_broadway_surface_set_urgency_hint;
   impl_class->set_geometry_hints = gdk_broadway_surface_set_geometry_hints;
   impl_class->set_title = gdk_broadway_surface_set_title;
   impl_class->set_startup_id = gdk_broadway_surface_set_startup_id;
index 7bfbc5d6374f835ccb162439cb7b7375058db6f6..f42b7c2715cc4a397fc46d6903f396f457d6731f 100644 (file)
@@ -4118,61 +4118,6 @@ gdk_surface_set_modal_hint (GdkSurface *surface,
   GDK_SURFACE_IMPL_GET_CLASS (surface->impl)->set_modal_hint (surface, modal);
 }
 
-/**
- * gdk_surface_set_skip_taskbar_hint:
- * @surface: a toplevel #GdkSurface
- * @skips_taskbar: %TRUE to skip the taskbar
- *
- * Toggles whether a surface should appear in a task list or surface
- * list. If a surface’s semantic type as specified with
- * gdk_surface_set_type_hint() already fully describes the surface, this
- * function should not be called in addition,
- * instead you should allow the surface to be treated according to
- * standard policy for its semantic type.
- **/
-void
-gdk_surface_set_skip_taskbar_hint (GdkSurface *surface,
-                                   gboolean   skips_taskbar)
-{
-  GDK_SURFACE_IMPL_GET_CLASS (surface->impl)->set_skip_taskbar_hint (surface, skips_taskbar);
-}
-
-/**
- * gdk_surface_set_skip_pager_hint:
- * @surface: a toplevel #GdkSurface
- * @skips_pager: %TRUE to skip the pager
- *
- * Toggles whether a surface should appear in a pager (workspace
- * switcher, or other desktop utility program that displays a small
- * thumbnail representation of the surfaces on the desktop). If a
- * surface’s semantic type as specified with gdk_surface_set_type_hint()
- * already fully describes the surface, this function should
- * not be called in addition, instead you should
- * allow the surface to be treated according to standard policy for
- * its semantic type.
- **/
-void
-gdk_surface_set_skip_pager_hint (GdkSurface *surface,
-                                 gboolean   skips_pager)
-{
-  GDK_SURFACE_IMPL_GET_CLASS (surface->impl)->set_skip_pager_hint (surface, skips_pager);
-}
-
-/**
- * gdk_surface_set_urgency_hint:
- * @surface: a toplevel #GdkSurface
- * @urgent: %TRUE if the surface is urgent
- *
- * Toggles whether a surface needs the user's
- * urgent attention.
- **/
-void
-gdk_surface_set_urgency_hint (GdkSurface *surface,
-                              gboolean   urgent)
-{
-  GDK_SURFACE_IMPL_GET_CLASS (surface->impl)->set_urgency_hint (surface, urgent);
-}
-
 /**
  * gdk_surface_set_geometry_hints:
  * @surface: a toplevel #GdkSurface
@@ -4259,7 +4204,7 @@ gdk_surface_set_startup_id (GdkSurface   *surface,
  **/
 void
 gdk_surface_set_transient_for (GdkSurface *surface,
-                              GdkSurface *parent)
+                               GdkSurface *parent)
 {
   surface->transient_for = parent;
 
index 8f1364f3da533bdeed397b53e4d3e3a35ca5144a..3b79cdc901103afd2423c7d7dddd1cde23d28986 100644 (file)
@@ -555,16 +555,6 @@ GDK_AVAILABLE_IN_ALL
 void          gdk_surface_set_modal_hint   (GdkSurface       *surface,
                                             gboolean         modal);
 
-GDK_AVAILABLE_IN_ALL
-void gdk_surface_set_skip_taskbar_hint (GdkSurface *surface,
-                                        gboolean   skips_taskbar);
-GDK_AVAILABLE_IN_ALL
-void gdk_surface_set_skip_pager_hint   (GdkSurface *surface,
-                                        gboolean   skips_pager);
-GDK_AVAILABLE_IN_ALL
-void gdk_surface_set_urgency_hint      (GdkSurface *surface,
-                                        gboolean   urgent);
-
 GDK_AVAILABLE_IN_ALL
 void          gdk_surface_set_geometry_hints (GdkSurface          *surface,
                                               const GdkGeometry  *geometry,
index 4dfc42e081f8675281a3d160ef7a8940499718e7..077ae458607a157e068aa19e704d4084041e87bc 100644 (file)
@@ -125,12 +125,6 @@ struct _GdkSurfaceImplClass
   GdkSurfaceTypeHint (* get_type_hint)   (GdkSurface       *surface);
   void         (* set_modal_hint)       (GdkSurface *surface,
                                          gboolean   modal);
-  void         (* set_skip_taskbar_hint) (GdkSurface *surface,
-                                          gboolean   skips_taskbar);
-  void         (* set_skip_pager_hint)  (GdkSurface *surface,
-                                         gboolean   skips_pager);
-  void         (* set_urgency_hint)     (GdkSurface *surface,
-                                         gboolean   urgent);
   void         (* set_geometry_hints)   (GdkSurface         *surface,
                                          const GdkGeometry *geometry,
                                          GdkSurfaceHints     geom_mask);
index 86ed03487ee032b709d4687cab0639720b7bbc19..14c07b0168396a69006604bcc53f51bdc2082e12 100644 (file)
@@ -1618,17 +1618,6 @@ gdk_surface_quartz_get_device_state (GdkSurface       *window,
                                                     x, y, mask) != NULL;
 }
 
-static void
-gdk_quartz_surface_set_urgency_hint (GdkSurface *window,
-                                    gboolean   urgent)
-{
-  if (GDK_SURFACE_DESTROYED (window) ||
-      !SURFACE_IS_TOPLEVEL (window))
-    return;
-
-  /* FIXME: Implement */
-}
-
 static void
 gdk_quartz_surface_set_geometry_hints (GdkSurface         *window,
                                       const GdkGeometry *geometry,
@@ -1997,28 +1986,6 @@ gdk_quartz_surface_set_modal_hint (GdkSurface *window,
   /* FIXME: Implement */
 }
 
-static void
-gdk_quartz_surface_set_skip_taskbar_hint (GdkSurface *window,
-                                         gboolean   skips_taskbar)
-{
-  if (GDK_SURFACE_DESTROYED (window) ||
-      !SURFACE_IS_TOPLEVEL (window))
-    return;
-
-  /* FIXME: Implement */
-}
-
-static void
-gdk_quartz_surface_set_skip_pager_hint (GdkSurface *window,
-                                       gboolean   skips_pager)
-{
-  if (GDK_SURFACE_DESTROYED (window) ||
-      !SURFACE_IS_TOPLEVEL (window))
-    return;
-
-  /* FIXME: Implement */
-}
-
 static void
 gdk_quartz_surface_begin_resize_drag (GdkSurface     *window,
                                      GdkSurfaceEdge  edge,
@@ -2738,9 +2705,6 @@ gdk_surface_impl_quartz_class_init (GdkSurfaceImplQuartzClass *klass)
   impl_class->set_type_hint = gdk_quartz_surface_set_type_hint;
   impl_class->get_type_hint = gdk_quartz_surface_get_type_hint;
   impl_class->set_modal_hint = gdk_quartz_surface_set_modal_hint;
-  impl_class->set_skip_taskbar_hint = gdk_quartz_surface_set_skip_taskbar_hint;
-  impl_class->set_skip_pager_hint = gdk_quartz_surface_set_skip_pager_hint;
-  impl_class->set_urgency_hint = gdk_quartz_surface_set_urgency_hint;
   impl_class->set_geometry_hints = gdk_quartz_surface_set_geometry_hints;
   impl_class->set_title = gdk_quartz_surface_set_title;
   impl_class->set_startup_id = gdk_quartz_surface_set_startup_id;
index 9e774c31b4b8aafc51421d27dc7c3439df0b0867..9b8bc8108ec6c66625d7bc7a631eb6e43c8e2ec1 100644 (file)
@@ -3063,24 +3063,6 @@ gdk_wayland_surface_set_modal_hint (GdkSurface *surface,
   maybe_set_gtk_surface_modal (surface);
 }
 
-static void
-gdk_wayland_surface_set_skip_taskbar_hint (GdkSurface *surface,
-                                           gboolean    skips_taskbar)
-{
-}
-
-static void
-gdk_wayland_surface_set_skip_pager_hint (GdkSurface *surface,
-                                         gboolean    skips_pager)
-{
-}
-
-static void
-gdk_wayland_surface_set_urgency_hint (GdkSurface *surface,
-                                      gboolean    urgent)
-{
-}
-
 static void
 gdk_wayland_surface_set_geometry_hints (GdkSurface         *surface,
                                         const GdkGeometry  *geometry,
@@ -3846,9 +3828,6 @@ _gdk_surface_impl_wayland_class_init (GdkSurfaceImplWaylandClass *klass)
   impl_class->set_type_hint = gdk_wayland_surface_set_type_hint;
   impl_class->get_type_hint = gdk_wayland_surface_get_type_hint;
   impl_class->set_modal_hint = gdk_wayland_surface_set_modal_hint;
-  impl_class->set_skip_taskbar_hint = gdk_wayland_surface_set_skip_taskbar_hint;
-  impl_class->set_skip_pager_hint = gdk_wayland_surface_set_skip_pager_hint;
-  impl_class->set_urgency_hint = gdk_wayland_surface_set_urgency_hint;
   impl_class->set_geometry_hints = gdk_wayland_surface_set_geometry_hints;
   impl_class->set_title = gdk_wayland_surface_set_title;
   impl_class->set_startup_id = gdk_wayland_surface_set_startup_id;
index e5a945c9bf1763abcc70966919349765e640f59e..bc8b82470dde82c3ec2bfbe88e7f601dee7dbc2b 100644 (file)
@@ -731,9 +731,6 @@ _gdk_win32_display_create_surface_impl (GdkDisplay    *display,
       return;
     }
 
-//  if (!from_set_skip_taskbar_hint && window->surface_type == GDK_SURFACE_TEMP)
-//    gdk_surface_set_skip_taskbar_hint (window, TRUE);
-
   _gdk_win32_surface_enable_transparency (window);
 
   frame_clock = gdk_surface_get_frame_clock (window);
@@ -1407,9 +1404,9 @@ gdk_win32_surface_lower (GdkSurface *window)
     }
 }
 
-static void
+void
 gdk_win32_surface_set_urgency_hint (GdkSurface *window,
-                            gboolean   urgent)
+                                    gboolean    urgent)
 {
   FLASHWINFO flashwinfo;
   typedef BOOL (WINAPI *PFN_FlashWindowEx) (FLASHWINFO*);
@@ -1503,8 +1500,6 @@ get_effective_window_decorations (GdkSurface       *window,
 
        case GDK_SURFACE_TYPE_HINT_TOOLBAR:
        case GDK_SURFACE_TYPE_HINT_UTILITY:
-         gdk_surface_set_skip_taskbar_hint (window, TRUE);
-         gdk_surface_set_skip_pager_hint (window, TRUE);
          *decoration = (GDK_DECOR_ALL | GDK_DECOR_MINIMIZE | GDK_DECOR_MAXIMIZE);
          return TRUE;
 
@@ -4890,63 +4885,6 @@ gdk_win32_surface_set_modal_hint (GdkSurface *window,
 #endif
 }
 
-static void
-gdk_win32_surface_set_skip_taskbar_hint (GdkSurface *window,
-                                 gboolean   skips_taskbar)
-{
-  static GdkSurface *owner = NULL;
-  //GdkSurfaceAttr wa;
-
-  g_return_if_fail (GDK_IS_SURFACE (window));
-
-  GDK_NOTE (MISC, g_print ("gdk_surface_set_skip_taskbar_hint: %p: %s, doing nothing\n",
-                          GDK_SURFACE_HWND (window),
-                          skips_taskbar ? "YES" : "NO"));
-
-  // ### TODO: Need to figure out what to do here.
-  return;
-
-  if (skips_taskbar)
-    {
-#if 0
-      if (owner == NULL)
-               {
-                 wa.surface_type = GDK_SURFACE_TEMP;
-                 wa.wclass = GDK_INPUT_OUTPUT;
-                 wa.width = wa.height = 1;
-                 owner = gdk_surface_new_internal (NULL, &wa, 0, TRUE);
-               }
-#endif
-
-      SetWindowLongPtr (GDK_SURFACE_HWND (window), GWLP_HWNDPARENT, (LONG_PTR) GDK_SURFACE_HWND (owner));
-
-#if 0 /* Should we also turn off the minimize and maximize buttons? */
-      SetWindowLong (GDK_SURFACE_HWND (window), GWL_STYLE,
-                    GetWindowLong (GDK_SURFACE_HWND (window), GWL_STYLE) & ~(WS_MINIMIZEBOX|WS_MAXIMIZEBOX|WS_SYSMENU));
-
-      SetWindowPos (GDK_SURFACE_HWND (window), SWP_NOZORDER_SPECIFIED,
-                   0, 0, 0, 0,
-                   SWP_FRAMECHANGED | SWP_NOACTIVATE | SWP_NOMOVE |
-                   SWP_NOREPOSITION | SWP_NOSIZE | SWP_NOZORDER);
-#endif
-    }
-  else
-    {
-      SetWindowLongPtr (GDK_SURFACE_HWND (window), GWLP_HWNDPARENT, 0);
-    }
-}
-
-static void
-gdk_win32_surface_set_skip_pager_hint (GdkSurface *window,
-                               gboolean   skips_pager)
-{
-  g_return_if_fail (GDK_IS_SURFACE (window));
-
-  GDK_NOTE (MISC, g_print ("gdk_surface_set_skip_pager_hint: %p: %s, doing nothing\n",
-                          GDK_SURFACE_HWND (window),
-                          skips_pager ? "YES" : "NO"));
-}
-
 static void
 gdk_win32_surface_set_type_hint (GdkSurface        *window,
                          GdkSurfaceTypeHint hint)
@@ -5311,9 +5249,6 @@ gdk_surface_impl_win32_class_init (GdkSurfaceImplWin32Class *klass)
   impl_class->set_type_hint = gdk_win32_surface_set_type_hint;
   impl_class->get_type_hint = gdk_win32_surface_get_type_hint;
   impl_class->set_modal_hint = gdk_win32_surface_set_modal_hint;
-  impl_class->set_skip_taskbar_hint = gdk_win32_surface_set_skip_taskbar_hint;
-  impl_class->set_skip_pager_hint = gdk_win32_surface_set_skip_pager_hint;
-  impl_class->set_urgency_hint = gdk_win32_surface_set_urgency_hint;
   impl_class->set_geometry_hints = gdk_win32_surface_set_geometry_hints;
   impl_class->set_title = gdk_win32_surface_set_title;
   //impl_class->set_startup_id = gdk_x11_surface_set_startup_id;
index 9dda179353ec883a6f43fdc91279b7eb1c06d072..f081a49aadb85b2840304230ee3f79caf937840e 100644 (file)
@@ -50,6 +50,10 @@ typedef struct _GdkWin32SurfaceClass GdkWin32SurfaceClass;
 GDK_AVAILABLE_IN_ALL
 GType    gdk_win32_surface_get_type          (void);
 
+GDK_AVAILABLE_IN_ALL
+void gdk_win32_surface_set_urgency_hint    (GdkSurface *surface,
+                                            gboolean    urgent);
+
 G_END_DECLS
 
 #endif /* __GDK_X11_SURFACE_H__ */
index 2e3714859ef79d58336c00c661ea0df60689286b..aa5eb9b5a453172ad8afb97cca242f8978fc863c 100644 (file)
@@ -1867,9 +1867,9 @@ gdk_x11_surface_set_modal_hint (GdkSurface *surface,
                             NULL);
 }
 
-static void
+void
 gdk_x11_surface_set_skip_taskbar_hint (GdkSurface *surface,
-                                     gboolean   skips_taskbar)
+                                       gboolean    skips_taskbar)
 {
   GdkToplevelX11 *toplevel;
   
@@ -1888,9 +1888,9 @@ gdk_x11_surface_set_skip_taskbar_hint (GdkSurface *surface,
                             NULL);
 }
 
-static void
+void
 gdk_x11_surface_set_skip_pager_hint (GdkSurface *surface,
-                                   gboolean   skips_pager)
+                                     gboolean    skips_pager)
 {
   GdkToplevelX11 *toplevel;
     
@@ -1909,9 +1909,9 @@ gdk_x11_surface_set_skip_pager_hint (GdkSurface *surface,
                             NULL);
 }
 
-static void
+void
 gdk_x11_surface_set_urgency_hint (GdkSurface *surface,
-                            gboolean   urgent)
+                                  gboolean    urgent)
 {
   GdkToplevelX11 *toplevel;
     
@@ -4658,9 +4658,6 @@ gdk_surface_impl_x11_class_init (GdkSurfaceImplX11Class *klass)
   impl_class->set_type_hint = gdk_x11_surface_set_type_hint;
   impl_class->get_type_hint = gdk_x11_surface_get_type_hint;
   impl_class->set_modal_hint = gdk_x11_surface_set_modal_hint;
-  impl_class->set_skip_taskbar_hint = gdk_x11_surface_set_skip_taskbar_hint;
-  impl_class->set_skip_pager_hint = gdk_x11_surface_set_skip_pager_hint;
-  impl_class->set_urgency_hint = gdk_x11_surface_set_urgency_hint;
   impl_class->set_geometry_hints = gdk_x11_surface_set_geometry_hints;
   impl_class->set_title = gdk_x11_surface_set_title;
   impl_class->set_startup_id = gdk_x11_surface_set_startup_id;
index bb23dbee71e9aab20970eae1c9424c6ae0cb2731..fcd6a8006d352ebaa54894fa1b297aed88b417c9 100644 (file)
@@ -105,6 +105,16 @@ GDK_AVAILABLE_IN_ALL
 GdkSurface  *gdk_x11_surface_lookup_for_display      (GdkDisplay *display,
                                                       Window      window);
 
+GDK_AVAILABLE_IN_ALL
+void gdk_x11_surface_set_skip_taskbar_hint (GdkSurface *surface,
+                                            gboolean    skips_taskbar);
+GDK_AVAILABLE_IN_ALL
+void gdk_x11_surface_set_skip_pager_hint   (GdkSurface *surface,
+                                            gboolean    skips_pager);
+GDK_AVAILABLE_IN_ALL
+void gdk_x11_surface_set_urgency_hint      (GdkSurface *surface,
+                                            gboolean    urgent);
+
 G_END_DECLS
 
 #endif /* __GDK_X11_SURFACE_H__ */
index 153616831f63e6c018637c5d2c31bcbc28a8d3a6..5d9923900cf3752285f28de86e71291b19ecae64 100644 (file)
  * convenience widget; you could construct the equivalent of #GtkMessageDialog
  * from #GtkDialog without too much effort, but #GtkMessageDialog saves typing.
  *
- * One difference from #GtkDialog is that #GtkMessageDialog sets the
- * #GtkWindow:skip-taskbar-hint property to %TRUE, so that the dialog is hidden
- * from the taskbar by default.
- *
  * The easiest way to do a modal message dialog is to use gtk_dialog_run(), though
  * you can also pass in the %GTK_DIALOG_MODAL flag, gtk_dialog_run() automatically
  * makes the dialog modal and waits for the user to respond to it. gtk_dialog_run()
index 5babfe6b124325129165314d5a5fa6e7fe41cb33..b3cb887443449630bdbf863e1c4aeae9214c7aa6 100644 (file)
@@ -254,12 +254,9 @@ typedef struct
   guint    modal                     : 1;
   guint    position                  : 3;
   guint    resizable                 : 1;
-  guint    skips_pager               : 1;
-  guint    skips_taskbar             : 1;
   guint    stick_initially           : 1;
   guint    transient_parent_group    : 1;
   guint    type                      : 4; /* GtkWindowType */
-  guint    urgent                    : 1;
   guint    gravity                   : 5; /* GdkGravity */
   guint    csd_requested             : 1;
   guint    client_decorated          : 1; /* Decorations drawn client-side */
@@ -321,9 +318,6 @@ enum {
   PROP_ICON_NAME,
   PROP_DISPLAY,
   PROP_TYPE_HINT,
-  PROP_SKIP_TASKBAR_HINT,
-  PROP_SKIP_PAGER_HINT,
-  PROP_URGENCY_HINT,
   PROP_ACCEPT_FOCUS,
   PROP_FOCUS_ON_MAP,
   PROP_DECORATED,
@@ -957,27 +951,6 @@ gtk_window_class_init (GtkWindowClass *klass)
                          GDK_SURFACE_TYPE_HINT_NORMAL,
                          GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
 
-  window_props[PROP_SKIP_TASKBAR_HINT] =
-      g_param_spec_boolean ("skip-taskbar-hint",
-                            P_("Skip taskbar"),
-                            P_("TRUE if the window should not be in the task bar."),
-                            FALSE,
-                            GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
-
-  window_props[PROP_SKIP_PAGER_HINT] =
-      g_param_spec_boolean ("skip-pager-hint",
-                            P_("Skip pager"),
-                            P_("TRUE if the window should not be in the pager."),
-                            FALSE,
-                            GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
-
-  window_props[PROP_URGENCY_HINT] =
-      g_param_spec_boolean ("urgency-hint",
-                            P_("Urgent"),
-                            P_("TRUE if the window should be brought to the user’s attention."),
-                            FALSE,
-                            GTK_PARAM_READWRITE|G_PARAM_EXPLICIT_NOTIFY);
-
   /**
    * GtkWindow:accept-focus:
    *
@@ -1989,18 +1962,6 @@ gtk_window_set_property (GObject      *object,
       gtk_window_set_type_hint (window,
                                 g_value_get_enum (value));
       break;
-    case PROP_SKIP_TASKBAR_HINT:
-      gtk_window_set_skip_taskbar_hint (window,
-                                        g_value_get_boolean (value));
-      break;
-    case PROP_SKIP_PAGER_HINT:
-      gtk_window_set_skip_pager_hint (window,
-                                      g_value_get_boolean (value));
-      break;
-    case PROP_URGENCY_HINT:
-      gtk_window_set_urgency_hint (window,
-                                  g_value_get_boolean (value));
-      break;
     case PROP_ACCEPT_FOCUS:
       gtk_window_set_accept_focus (window,
                                   g_value_get_boolean (value));
@@ -2098,18 +2059,6 @@ gtk_window_get_property (GObject      *object,
     case PROP_TYPE_HINT:
       g_value_set_enum (value, priv->type_hint);
       break;
-    case PROP_SKIP_TASKBAR_HINT:
-      g_value_set_boolean (value,
-                           gtk_window_get_skip_taskbar_hint (window));
-      break;
-    case PROP_SKIP_PAGER_HINT:
-      g_value_set_boolean (value,
-                           gtk_window_get_skip_pager_hint (window));
-      break;
-    case PROP_URGENCY_HINT:
-      g_value_set_boolean (value,
-                           gtk_window_get_urgency_hint (window));
-      break;
     case PROP_ACCEPT_FOCUS:
       g_value_set_boolean (value,
                            gtk_window_get_accept_focus (window));
@@ -3523,147 +3472,6 @@ gtk_window_get_type_hint (GtkWindow *window)
   return priv->type_hint;
 }
 
-/**
- * gtk_window_set_skip_taskbar_hint:
- * @window: a #GtkWindow 
- * @setting: %TRUE to keep this window from appearing in the task bar
- * 
- * Windows may set a hint asking the desktop environment not to display
- * the window in the task bar. This function sets this hint.
- **/
-void
-gtk_window_set_skip_taskbar_hint (GtkWindow *window,
-                                  gboolean   setting)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_if_fail (GTK_IS_WINDOW (window));
-
-  setting = setting != FALSE;
-
-  if (priv->skips_taskbar != setting)
-    {
-      priv->skips_taskbar = setting;
-      if (_gtk_widget_get_realized (GTK_WIDGET (window)))
-        gdk_surface_set_skip_taskbar_hint (_gtk_widget_get_surface (GTK_WIDGET (window)),
-                                          priv->skips_taskbar);
-      g_object_notify_by_pspec (G_OBJECT (window), window_props[PROP_SKIP_TASKBAR_HINT]);
-    }
-}
-
-/**
- * gtk_window_get_skip_taskbar_hint:
- * @window: a #GtkWindow
- * 
- * Gets the value set by gtk_window_set_skip_taskbar_hint()
- * 
- * Returns: %TRUE if window shouldn’t be in taskbar
- **/
-gboolean
-gtk_window_get_skip_taskbar_hint (GtkWindow *window)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_val_if_fail (GTK_IS_WINDOW (window), FALSE);
-
-  return priv->skips_taskbar;
-}
-
-/**
- * gtk_window_set_skip_pager_hint:
- * @window: a #GtkWindow 
- * @setting: %TRUE to keep this window from appearing in the pager
- * 
- * Windows may set a hint asking the desktop environment not to display
- * the window in the pager. This function sets this hint.
- * (A "pager" is any desktop navigation tool such as a workspace
- * switcher that displays a thumbnail representation of the windows
- * on the screen.)
- **/
-void
-gtk_window_set_skip_pager_hint (GtkWindow *window,
-                                gboolean   setting)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_if_fail (GTK_IS_WINDOW (window));
-
-  setting = setting != FALSE;
-
-  if (priv->skips_pager != setting)
-    {
-      priv->skips_pager = setting;
-      if (_gtk_widget_get_realized (GTK_WIDGET (window)))
-        gdk_surface_set_skip_pager_hint (_gtk_widget_get_surface (GTK_WIDGET (window)),
-                                        priv->skips_pager);
-      g_object_notify_by_pspec (G_OBJECT (window), window_props[PROP_SKIP_PAGER_HINT]);
-    }
-}
-
-/**
- * gtk_window_get_skip_pager_hint:
- * @window: a #GtkWindow
- * 
- * Gets the value set by gtk_window_set_skip_pager_hint().
- * 
- * Returns: %TRUE if window shouldn’t be in pager
- **/
-gboolean
-gtk_window_get_skip_pager_hint (GtkWindow *window)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_val_if_fail (GTK_IS_WINDOW (window), FALSE);
-
-  return priv->skips_pager;
-}
-
-/**
- * gtk_window_set_urgency_hint:
- * @window: a #GtkWindow 
- * @setting: %TRUE to mark this window as urgent
- * 
- * Windows may set a hint asking the desktop environment to draw
- * the users attention to the window. This function sets this hint.
- **/
-void
-gtk_window_set_urgency_hint (GtkWindow *window,
-                            gboolean   setting)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_if_fail (GTK_IS_WINDOW (window));
-
-  setting = setting != FALSE;
-
-  if (priv->urgent != setting)
-    {
-      priv->urgent = setting;
-      if (_gtk_widget_get_realized (GTK_WIDGET (window)))
-        gdk_surface_set_urgency_hint (_gtk_widget_get_surface (GTK_WIDGET (window)),
-                                    priv->urgent);
-      g_object_notify_by_pspec (G_OBJECT (window), window_props[PROP_URGENCY_HINT]);
-    }
-}
-
-/**
- * gtk_window_get_urgency_hint:
- * @window: a #GtkWindow
- * 
- * Gets the value set by gtk_window_set_urgency_hint()
- * 
- * Returns: %TRUE if window is urgent
- **/
-gboolean
-gtk_window_get_urgency_hint (GtkWindow *window)
-{
-  GtkWindowPrivate *priv = gtk_window_get_instance_private (window);
-
-  g_return_val_if_fail (GTK_IS_WINDOW (window), FALSE);
-
-  return priv->urgent;
-}
-
 /**
  * gtk_window_set_accept_focus:
  * @window: a #GtkWindow 
@@ -5878,12 +5686,6 @@ gtk_window_realize (GtkWidget *widget)
   if (!priv->deletable)
     gdk_surface_set_functions (surface, GDK_FUNC_ALL | GDK_FUNC_CLOSE);
 
-  if (gtk_window_get_skip_pager_hint (window))
-    gdk_surface_set_skip_pager_hint (surface, TRUE);
-
-  if (gtk_window_get_skip_taskbar_hint (window))
-    gdk_surface_set_skip_taskbar_hint (surface, TRUE);
-
   if (gtk_window_get_accept_focus (window))
     gdk_surface_set_accept_focus (surface, TRUE);
   else
index c2ec33b1974f569f05fa02fbe17d25c00384d89a..128136bc95e5811bb48e3362c93841cfd79f1aaa 100644 (file)
@@ -4,7 +4,6 @@
     <property name="title"></property>
     <property name="resizable">0</property>
     <property name="type-hint">dialog</property>
-    <property name="skip-taskbar-hint">1</property>
     <child internal-child="headerbar">
       <object class="GtkHeaderBar" id="headerbar1"/>
     </child>